asp.net - Any way I can make this code cleaner/more efficient? (C#/LINQ-to-SQL) -

-

i've been putting auditing solution program developing, using linq update/insert operations. have come following solution (this snippet inserting) (note tables variable contains list of tables have been modified - add these list manually , call method):

 bindingflags b = bindingflags.instance | bindingflags.public;         linqdatacontext dc = new linqdatacontext();         foreach (object table in tables)         {             string tablename = table.tostring().replace("project.", "");              switch (tablename)             {                 case "job":                     string newjobstring = null;                     job jobdetails = (job)table;                     var prpsjob = typeof(job).getproperties(b);                     foreach (var p in prpsjob)                     {                         object x = p.getgetmethod().invoke(jobdetails, null);                         x = stripdate(x);                         newjobstring += p.name + ": " + x + environment.newline;                     }                     audit(jobid, newjobstring, "new job created", sourceid, "", jobdetails.jobid);                     break;                  case "estimation":                     string newestimationsstring = null;                     estimation estimationdetails = (estimation)table;                     var prpsestimations = typeof(estimation).getproperties(b);                     foreach (var p in prpsestimations)                     {                         object x = p.getgetmethod().invoke(estimationdetails, null);                         x = stripdate(x);                         newestimationsstring += p.name + ": " + x + environment.newline;                     }                     audit(jobid, newestimationsstring, "new estimation created", sourceid, "", estimationdetails.estimationid);                     break;

and code goes on each possible tablename. code works fine, seems inefficient - having identical block each case. there more efficient way?

you should able use lambdas cover type-specific parts of repeated code. pseudo-code hacked together....

void tableisjob(job j, bindingflags b) {    handletable("job", j.jobid, typeof(job).getproperties(b),                p=>p.getgetmethod().invoke(j, null)); }   void tableisestimation(estimation e, bindingflags b) {    handletable("estimation", e.estimationid, typeof(estimation).getproperties(b),        p => p.getgetmethod().invoke(e, null)); }  void handletable(string nm, int id, propertyinfo [] props, func<propertyinf, object> i) {        string desc = string.join(environment.newline, props.select(p=>{                        return string.format("{0}: {1}", p.name,                                     stripdate(i(p)));                }).toarray());        audit(jobid, desc, string.format("new {0} created", nm),              sourceid, "", id); }

and can replace huge loop , switch case with...

tables.select(t => {    switch (t.tostring().replace("project.", ""))    {        case "job":            tableisjob((job)t, b);            break;        case "estimation":            tableisestimation((estimation)t, b);            break;    } });

this assuming "efficient" means in terms of code volume, not in execution time.


Comments

Post a Comment

Popular posts from this blog

c# - How to set Z index when using WPF DrawingContext? -

-
how set z-index drawing object when using drawingcontext.drawxxx() methods? the object drawn last have higher z index. can't change index of drawn objects. way draw in order. if using wpf (as placed tag), can use, example, canvas control. create shapes need like polyline obj = new polyline(); //... // ... set properties of obj and add them canvas uielementcollection: yourcanvasname.children.add(obj); //or yourcanvasname.children.insert(i, obj); first items of collection have higher z index. advantages in way: no need redraw on window changes, can anytime move objects , change order.
Read more

razor - Is this a bug in WebMatrix PageData? -

-
i think may have found bug in webmatrix's pagedata, not sure. concerns how pass data partial page calling page. in webmatrix documentation (tutorials, e.g. " 3 - creating consistent look ", , example code), pagedata recommended mechanism pass data between pages (e.g. content page layout page, or partial page). however have found not work other way, pass data partial page calling page. modifying or adding entries in pagedata in partial page, not seem calling page. cutting right down simplest possible example, in test page may have this: @{ pagedata["test"] = "initial entry"; } <p>before calling partial page, test value @pagedata["test"]</p> @renderpage("_testpartial.cshtml") <p>after returning calling page, test value @pagedata["test"]</p> and in _testpartial.cshtml page might have this: @{ pagedata["test"] = "modified entry"; } <p>in partial page...
Read more

android - layout with fragment and framelayout replaced by another fragment and framelayout -

-
edit: so after comments below, revisted , realized hanging me up. imagine client list , client details activity started : public class clientsmainactivity extends fragmentactivity { @override public void oncreate(bundle savedinstancestate) { super.oncreate(savedinstancestate); //studiotabopenhelper db; setcontentview(r.layout.main_client_activity); } } so works great, starts main_client_activity (defined in layout below, , call activity when button on main screen clicked): intent intent = new intent(getactivity(), clientsmainactivity.class); startactivity(intent); easy issue is, clientsmainactivity not call oncreateview or anything, sets layout layout defines fragment, , listfragment. fine cause not trying pass clientsmainactivity , if have hypothetical activity like: sessionmainsactivity called when click on session edit of client, not calling sessionsmainactivity same way (starts activity sets alayout), want layout set defines...
Read more