ruby on rails - Good practice for protecting methods -

-

being newbie ror developer i've been thinking of ways of protecting methods make sure correct user updating own content. here example of approach.

would recommend cleaner way or better way of doing such tasks?

# example controller  class owner::propertiescontroller < owner::basecontroller    def index   end    etc.....    def update     @property = property.find(params[:id])      # check correct owner      check_owner(:owner_id => @property.owner_id)      if @property.update_attributes(params[:property])       redirect_to([:owner, @property], :notice => 'property updated.')     else       render :action => "edit"     end    end    def destroy     @property = property.find(params[:id])      # check correct owner      check_owner(:owner_id => @property.owner_id)      @property.destroy     redirect_to(owner_properties_url)   end    private    def check_owner p = {}     if p[:owner_id] != session[:owner_id]       redirect_to([:owner, @property], :notice => "property not found.")     end   end

you use gem declarative_authorization well. if want recommend drying code little bit:

class owner::propertiescontroller < owner::basecontroller   before_filter :check_owner, :only => [:update, :destroy]    def update     if @property.update_attributes(params[:property])       redirect_to([:owner, @property], :notice => 'property updated.')     else       render :action => "edit"     end   end    def destroy     @property.destroy     redirect_to(owner_properties_url)   end    private    def check_owner     @property = property.find(params[:id]      if @property.owner_id != session[:owner_id]       redirect_to([:owner, @property], :notice => "property not found.") , return     end   end end

additionally, can filter properties owner ensure user not owner can not interact properties aren't his/hers. example:

def update   @owner = owner.find(session[:owner_id])   @property = @owner.properties.find(params[:id])   redirect_to unauthorized_page , return if @property.nil? end

this forces properties searching ones belong session[:owner_id] instead of entire universe of properties. means properties session[:owner_id] not own not considered. can put code before_filter it's reusable in multiple actions.


Comments

Post a Comment

Popular posts from this blog

c# - How to set Z index when using WPF DrawingContext? -

-
how set z-index drawing object when using drawingcontext.drawxxx() methods? the object drawn last have higher z index. can't change index of drawn objects. way draw in order. if using wpf (as placed tag), can use, example, canvas control. create shapes need like polyline obj = new polyline(); //... // ... set properties of obj and add them canvas uielementcollection: yourcanvasname.children.add(obj); //or yourcanvasname.children.insert(i, obj); first items of collection have higher z index. advantages in way: no need redraw on window changes, can anytime move objects , change order.
Read more

razor - Is this a bug in WebMatrix PageData? -

-
i think may have found bug in webmatrix's pagedata, not sure. concerns how pass data partial page calling page. in webmatrix documentation (tutorials, e.g. " 3 - creating consistent look ", , example code), pagedata recommended mechanism pass data between pages (e.g. content page layout page, or partial page). however have found not work other way, pass data partial page calling page. modifying or adding entries in pagedata in partial page, not seem calling page. cutting right down simplest possible example, in test page may have this: @{ pagedata["test"] = "initial entry"; } <p>before calling partial page, test value @pagedata["test"]</p> @renderpage("_testpartial.cshtml") <p>after returning calling page, test value @pagedata["test"]</p> and in _testpartial.cshtml page might have this: @{ pagedata["test"] = "modified entry"; } <p>in partial page...
Read more

visual c++ - Using relative values in array sorting ( asm ) -

-
i need sort through array , sort each individual row in array in ascending order. doesn't seem going (surprise!) keep getting hit 2 errors: a2101: cannot add 2 relocatable labels , a2026: constant expected here's sort, makes sense me, think i'm still trying implement high-lvl language techniqes assembly. there way around not being able use relative values? (the array 7 rows 9 columns, btw). mov cx, 7; cx = number of rows outer: ; outer loop walk through rows push cx mov cx, 9 mov row, cx ;rows middle: ; middle-loop walk through columns push cx sub cx, 1 ;cx = cx-1 mov column, cx ;columns inner: ;inner loop - compare , exchange column values cmp marray[row*9 + column], marray[row*9 + column+1] xchg marray[row*9 + column+1], marray[row*9 + column] ; compare , exchange values marray table inc column loop inner pop cx loop mid...
Read more